Skip to content

Commit

Permalink
[EuiStep(s)Horizontal] Add HTML element type extensions (#4166)
Browse files Browse the repository at this point in the history
* add htmlbuttonelment type extension

* add htmlolistelment type extension

* CL
  • Loading branch information
thompsongl authored Oct 27, 2020
1 parent b7de5b3 commit a0bc3f1
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 3 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
**Bug fixes**

- Fixed issue with duplicate checkmarks in `EuiComboBox` ([#4162](https://github.com/elastic/eui/pull/4162))
- Reinstated base element type extensions for `EuiStepHorizontal` and `EuiStepsHorizontal` ([4166](https://github.com/elastic/eui/pull/4166))

## [`30.0.0`](https://github.com/elastic/eui/tree/v30.0.0)

Expand Down
5 changes: 4 additions & 1 deletion src/components/steps/step_horizontal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

import classNames from 'classnames';
import React, {
ButtonHTMLAttributes,
FunctionComponent,
MouseEvent as ReactMouseEvent,
MouseEventHandler,
Expand All @@ -33,7 +34,9 @@ import {
useI18nWarningStep,
} from './step_strings';

export interface EuiStepHorizontalProps extends CommonProps {
export interface EuiStepHorizontalProps
extends Omit<ButtonHTMLAttributes<HTMLButtonElement>, 'onClick'>,
CommonProps {
/**
* Is the current step
*/
Expand Down
6 changes: 4 additions & 2 deletions src/components/steps/steps_horizontal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,13 @@
*/

import classNames from 'classnames';
import React, { FunctionComponent } from 'react';
import React, { FunctionComponent, OlHTMLAttributes } from 'react';
import { CommonProps } from '../common';
import { EuiStepHorizontal, EuiStepHorizontalProps } from './step_horizontal';

export interface EuiStepsHorizontalProps extends CommonProps {
export interface EuiStepsHorizontalProps
extends OlHTMLAttributes<HTMLOListElement>,
CommonProps {
/**
* An array of `EuiStepHorizontal` objects excluding the `step` prop
*/
Expand Down

0 comments on commit a0bc3f1

Please sign in to comment.