Skip to content

Commit

Permalink
πŸ› Fix bizarre checkbox bug that only affects header cells
Browse files Browse the repository at this point in the history
  • Loading branch information
cee-chen committed Apr 2, 2024
1 parent 6a3728e commit bc8ebbd
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion src/components/table/table_cells_shared.styles.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,11 @@
import { css } from '@emotion/react';

import { UseEuiTheme } from '../../services';
import { euiFontSize, logicalCSS } from '../../global_styling';
import {
euiFontSize,
logicalCSS,
logicalTextAlignCSS,
} from '../../global_styling';

import { euiTableVariables } from './table.styles';

Expand Down Expand Up @@ -64,6 +68,10 @@ export const euiTableCellCheckboxStyles = (euiThemeContext: UseEuiTheme) => {
return {
euiTableHeaderCellCheckbox: css`
${sharedCheckboxStyles}
/* Without this the visually hidden checkbox doesn't line up properly with the custom render πŸ™ƒ
TODO: Could be removed if we use inset: 0 on checkboxes once they're converted to Emotion */
${logicalTextAlignCSS('left')}
`,
euiTableRowCellCheckbox: css`
${sharedCheckboxStyles}
Expand Down

0 comments on commit bc8ebbd

Please sign in to comment.