Skip to content

Commit

Permalink
[Pagination] - Added props doc mentioning the activePage is zero based (
Browse files Browse the repository at this point in the history
#1740)

* [Pagination] - Added props doc mentioning the activePage is zero based

* [Pagination] - Updated Changelog

* Code Review - Moved Changelog entry to current master
  • Loading branch information
theodesp authored and thompsongl committed Mar 20, 2019
1 parent bc991d4 commit c1ec28e
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## [`master`](https://github.com/elastic/eui/tree/master)

- Added documentation entry in `EuiPagination` for `activePage` prop. ([#1740](https://github.com/elastic/eui/pull/1740))
- Changed `EuiButton` to use "m" as it's default `size` prop ([#1742](https://github.com/elastic/eui/pull/1742))

## [`9.4.2`](https://github.com/elastic/eui/tree/v9.4.2)
Expand Down
7 changes: 6 additions & 1 deletion src/components/pagination/pagination.js
Original file line number Diff line number Diff line change
Expand Up @@ -186,9 +186,14 @@ EuiPagination.propTypes = {
className: PropTypes.string,

/**
* The total number of pages
* The total number of pages.
*/
pageCount: PropTypes.number,

/**
* The current page using a zero based index.
* So if you set the activePage to 1, it will activate the second page.
*/
activePage: PropTypes.number,
onPageClick: PropTypes.func,

Expand Down

0 comments on commit c1ec28e

Please sign in to comment.