Skip to content

Commit

Permalink
[Tech debt] Update various linter ignore files (#5045)
Browse files Browse the repository at this point in the history
* [stylelint] Ignore non-scss files

* [eslint] Ignore non src/src-docs files that contain JS files

- the folders added in this commit already contain multiple eslint violations and likely shouldn't report problems in VSCode if we're not checking for them in CI

* [eslint] Remove unused .snap.js ignore

- we currently don't have any files with this format - they all end in .snap which eslint doesn't parse in any case

* [eslint][opinionated] Specify js icon assets being ignored

- these appear to only be located in src/components/icons, and I thought it would be more helpful to specifically list that folder to potentially make cleaning it up easier in the future, and also to avoid skipping linting on other asset files that might want it

* [eslint] Remove singleton file being ignored

- in favor of just fixing the lint complaints within the file
  • Loading branch information
Constance authored Aug 20, 2021
1 parent af9d6b9 commit ed83754
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 8 deletions.
9 changes: 5 additions & 4 deletions .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@ lib
test-env
types
eui.d.ts
**/*.snap.js
**/assets/**/*.js
src/components/icon/assets/**/*.js
package.json
src-docs/src/views/icon/icon_example.js
packages/react-datepicker/examples
docs
packages
scripts
generator-eui
10 changes: 8 additions & 2 deletions .stylelintrc
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,11 @@
"rules": {
"number-leading-zero": "never",
"color-hex-case": "upper"
}
}
},
"ignoreFiles": [
"**/*.ts",
"**/*.tsx",
"**/*.js",
"**/*.jsx",
]
}
4 changes: 2 additions & 2 deletions src-docs/src/views/icon/icon_example.js
Original file line number Diff line number Diff line change
Expand Up @@ -211,8 +211,8 @@ export const IconExample = {
Two-tone icons, like our app style icons, will behave similarly to
normal glyphs when provided a specific color by applying the color
to <strong>all</strong> the shapes within. You can force the icon
to match the parent's text color by passing{' '}
<EuiCode>color="inherit"</EuiCode> to the icon.
to match the parent&apos;s text color by passing{' '}
<EuiCode>color=&#34;inherit&#34;</EuiCode> to the icon.
</p>
</EuiText>
</>
Expand Down

0 comments on commit ed83754

Please sign in to comment.