Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EuiInMemoryTable's "Rows per page" won't stay open in Popover #1043

Closed
legrego opened this issue Jul 23, 2018 · 2 comments
Closed

EuiInMemoryTable's "Rows per page" won't stay open in Popover #1043

legrego opened this issue Jul 23, 2018 · 2 comments

Comments

@legrego
Copy link
Member

legrego commented Jul 23, 2018

Tested on both 3.0.0 and 3.1.0.

paging in popover

When trying to change the number of results per page, the page size selector apprears for a split-second, then disappears on its own.

Essentially, I have an EuiInMemoryTable defined within an EuiPopover:

<EuiPopover button={button} isOpen={this.state.isOpen} closePopover={this.closePortal} anchorPosition={'rightCenter'}>
  <EuiInMemoryTable
    itemId={"id"}
    items={this.props.spaces}
    columns={this.getColumnConfig()}
    pagination={{
      initialPageSize: 10,
    }}
    search={{
      box: {
        incremental: true
      }
    }}
  />
</EuiPopover>
)

The example above is slightly simplified, but I can post a full sample if needed

@chandlerprall
Copy link
Contributor

This was fixed in #1039, but that fix is unreleased; I'll cut a new release.

@legrego
Copy link
Member Author

legrego commented Jul 23, 2018

Fixed in 3.2.0!

@legrego legrego closed this as completed Jul 23, 2018
legrego added a commit to elastic/kibana that referenced this issue Aug 16, 2018
…19497)

This replaces the existing Modal with a smaller Popover which is less intrusive. The popover also features a search bar for finding the desired Space when there are 8 or more Spaces to choose from.

### Details
When there are less than 8 spaces available, the selector will render a simple list of spaces.

When there are >= 8 spaces available, the selector will also render a search bar to let users search for their space.


### Prerequisites 
- [x] Merge #18862 into `spaces-phase-1`

### Known Issues
- elastic/eui#1043 (fixed in `v3.2.0`)
- elastic/eui#1052 (fixed in `v3.2.1`)
- Missing typdefs (not a blocker to merge): elastic/eui#1120
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants