-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiPopover] should default to ownFocus
#4222
Comments
It's not a breaking change because it doesn't require consumers to afford for the change. |
Re-opening this because the fix is being reverted for now, as the focus trap causes issues with popovers in Kibana's top navigation. |
Now that we're after the winter holidays, should we try this one more time? |
We def should, but it'll need to wait until after the datagrid virtualization & emotion theming unless you want to own it 😃 |
ownFocus={false}
isn't really accessible in most situations so changing the default should be a good improvementIs this considered a breaking change? I don't really think so practically but I think it is technically...
The text was updated successfully, but these errors were encountered: