Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiPopover] should default to ownFocus #4222

Closed
myasonik opened this issue Nov 3, 2020 · 4 comments · Fixed by #4228 or #4551
Closed

[EuiPopover] should default to ownFocus #4222

myasonik opened this issue Nov 3, 2020 · 4 comments · Fixed by #4228 or #4551

Comments

@myasonik
Copy link
Contributor

myasonik commented Nov 3, 2020

ownFocus={false} isn't really accessible in most situations so changing the default should be a good improvement

Is this considered a breaking change? I don't really think so practically but I think it is technically...

@cchaos
Copy link
Contributor

cchaos commented Nov 3, 2020

It's not a breaking change because it doesn't require consumers to afford for the change.

@chandlerprall
Copy link
Contributor

chandlerprall commented Nov 25, 2020

Re-opening this because the fix is being reverted for now, as the focus trap causes issues with popovers in Kibana's top navigation.

@myasonik
Copy link
Contributor Author

Now that we're after the winter holidays, should we try this one more time?

@chandlerprall
Copy link
Contributor

We def should, but it'll need to wait until after the datagrid virtualization & emotion theming unless you want to own it 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants