[EuiPopover] Default to ownFocus #4551
Conversation
Co-authored-by: Elizabet Oliveira <[email protected]> Co-authored-by: Caroline Horn <[email protected]> Co-authored-by: Chandler Prall <[email protected]>
myasonik
force-pushed
the
ownFocus-default
branch
from
df90c3b
to
50e5206
Compare
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4551/ |
|
Can you remind me exactly what the problem was during the Kibana upgrade? |
|
So one of the two issues mentioned in #4311 is now closed. And the other, being around focus trapping, has changed so much in EUI since we last tried, that I think almost anything could happen (could be magically fixed, could be magically worse). Either way, I think just trying the upgrade again, hopefully without much time pressure, is going to be the way forward. CC @chandlerprall who was doing the upgrade - maybe he remembers more details |
|
Thanks!
My suggestion with this PR, then, is to ensure we're good Kibana-side with a local |
|
The last-encountered hurdle in the previous Kibana upgrade attempt was the top nav dropdowns (e.g. "Alerts") wouldn't close for some reason. Echoing Caroline here, we'll want to test this PR heavily with a custom build in Kibana before merging. |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4551/ |
|
Tested with a local version of EUI packaged into Kibana and everything seems to work! (Tested in FF, Chrome and Safari.) |
|
Changes look good (and I pushed 3 more removals of |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4551/ |
|
The menu popovers close now, but seeing Discover's Inspect flyout remaining open. Unsure if this is a bug in
|
|
I'm able to reproduce on master - opened elastic/kibana#92903 |
|
Great - kinda 😁 Last thing I want to test is this change with a full kibana functional test pass. Think I have a way to do that on Kibana's CI without making an EUI release. |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4551/ |
Summary
After the initial attempt was reverted this again sets
ownFocusto default totruefor EuiPopover.Closes #4222
From the last time we tried upgrading Kibana with this update, we know the update will take some time/work so doing it now (at the very start of 7.13) would be good timing.
Checklist
[ ] Check against all themes for compatibility in both light and dark modes[ ] Checked in mobile[ ] Props have proper autodocs and playground toggles[ ] Added documentation[ ] Checked Code Sandbox works for the any docs examples