Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiInMemoryTable] add the ability to control the spacer's size when using childrenBetween #4246

Closed
pgayvallet opened this issue Nov 10, 2020 · 1 comment · Fixed by #4248
Assignees

Comments

@pgayvallet
Copy link

#4103 Introduced a new childrenBetween property to EuiInMemoryTable to inject arbitrary content between the search bar and the actual table. However currently, using the childrenBetween property automatically adds a spacer between the content and the table, without letting the developer have any control over it:

https://github.com/elastic/eui/blob/master/src/components/basic_table/in_memory_table.tsx#L695

In some designs, such as the SO tagging management screen in Kibana, we need to get rid of this spacer to have the custom content directly on top of the table:

Screenshot 2020-11-10 at 17 38 26

A possible solution would be to add a childrenBetweenSpacerSize property. After a discussion with @cchaos, it seems that just removing this spacer altogether and relying on the developer to add it manually when they need to do so would also makes sense.

@cchaos
Copy link
Contributor

cchaos commented Nov 10, 2020

I think we can easily just remove this spacer altogether. It will rely on consumers to then add their own, but is an easier solution to customize and maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants