Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saved object tagging: Remove hack to suppress spacer within the EuiInMemoryTable #83161

Open
pgayvallet opened this issue Nov 11, 2020 · 1 comment
Open

Saved object tagging: Remove hack to suppress spacer within the EuiInMemoryTable #83161

pgayvallet opened this issue Nov 11, 2020 · 1 comment
Labels
chore Feature:Saved Object Tagging Saved Objects Tagging feature old Used to help sort old issues on GH Projects which don't support the Created search term. Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@pgayvallet
Copy link
Contributor

Initial discussion: #82816 (comment)

In #82816 we implemented the 'bulk action' menu for the tag management section.

To use the correct design, we had to introduce a css hack to hide the spacer that is between the tag action bar and the table.

This is a violation of EUI guidelines. A PR has already been merged upstream to address the root issue: elastic/eui#4246.

When this fix got integrated into Kibana during next EUI upgrade, we need to remove the hack
@pgayvallet pgayvallet added chore Feature:Saved Object Tagging Saved Objects Tagging feature labels Nov 11, 2020
@pgayvallet pgayvallet mentioned this issue Nov 11, 2020
Merged
6 tasks
@tsullivan tsullivan added the Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) label Feb 13, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@petrklapka petrklapka added the old Used to help sort old issues on GH Projects which don't support the Created search term. label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Feature:Saved Object Tagging Saved Objects Tagging feature old Used to help sort old issues on GH Projects which don't support the Created search term. Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tsullivan @pgayvallet @elasticmachine @petrklapka