Fix width of filter group items #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I actually did edit the docs. I removed that manual classname to the popover. |
chandlerprall
approved these changes
Aug 2, 2018
|
I'll also double-check IE before I merge. |
|
I just checked IE, and the filter group example is fine, but the search bar example's popover doesn't adjust it's width after the loading anim goes away and the items are loaded in. @chandlerprall any thought? |
snide
approved these changes
Aug 2, 2018
|
@cchaos the filter bar is positioned incorrectly for me in both IE11 and Edge I see the incorrect width of the search bar's Tag filter in IE11, digging into that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
display: blockto the items ensures the elements are only as wide as they need to be (somehow).Also removed the max-width of the filter group popover since it's being overridden and also just unnecessary because of the actual fix and that it's a manual class vs component class.