Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more css text utilities #1092

Merged
merged 4 commits into from
Aug 7, 2018
Merged

Added more css text utilities #1092

merged 4 commits into from
Aug 7, 2018

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented Aug 7, 2018

  • Moved properties from .eui-textTruncate into a mixin and including that mixin in the utility class
  • Added .eui-textBreakNormal in case consumers need to override a applied word-break: break-all
  • Using the above class on props doc table contents to fix Set nowrap on props definitions #678

screen shot 2018-08-07 at 12 12 33 pm

- Moved properties from `.eui-textTruncate` into a mixin and including that mixin in the utility class
- Added `.eui-textBreakNormal` in case consumers need to override a applied `word-break: break-all`
- Using the above class on props doc table contents to fix elastic#678
@cchaos cchaos added style only documentation Issues or PRs that only affect documentation - will not need changelog entries labels Aug 7, 2018
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'll defer to @snide to approve :)

Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this one. Was so annoying.

CHANGELOG.md Outdated
@@ -6,6 +6,7 @@
- Added `repositionOnScroll` prop to `EuiPopover` which enables repositioning the popover when the window is scrolled. ([#1064](https://github.com/elastic/eui/pull/1064))
- Allow `_` and `*` characters to be used in `EuiSearchBar` query terms ([#1058](https://github.com/elastic/eui/pull/1058))
- Added more `status` options for `EuiSteps` ([#1088](https://github.com/elastic/eui/pull/1088))
- Added more `.eui-textBreakNormal` and `@mixin euiTextTruncate` as CSS/SASS utilities ([#1092](https://github.com/elastic/eui/pull/1092))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy/pasta "more".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hehe

@cchaos cchaos merged commit a9e584e into elastic:master Aug 7, 2018
@cchaos cchaos deleted the break-normal branch August 7, 2018 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set nowrap on props definitions
3 participants