Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to shown options for several different fields in same filter #1179

Merged
merged 4 commits into from
Sep 10, 2018
Merged

Add ability to shown options for several different fields in same filter #1179

merged 4 commits into from
Sep 10, 2018

Conversation

bevacqua
Copy link
Contributor

Fixes #1172 by allowing value select filters to have fields on a per-option granularity

chandlerprall
chandlerprall reviewed Sep 10, 2018
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests in field_value_selection_filter.test.js around the activeTop / activeItem logic. Just a UI render test against if an input query enables the active state.

@bevacqua
Copy link
Contributor Author

Added tests for various active/inactive cases

chandlerprall
chandlerprall approved these changes Sep 10, 2018
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, pulled branch and tested in browser too

@bevacqua bevacqua merged commit 1da565f into elastic:master Sep 10, 2018
@bevacqua bevacqua deleted the multi-field-value-selection-filters branch September 10, 2018 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandlerprall chandlerprall chandlerprall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bevacqua @chandlerprall