Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility/tables #1181

Merged
merged 3 commits into from
Sep 11, 2018
Merged

Accessibility/tables #1181

merged 3 commits into from
Sep 11, 2018

Conversation

snide
Copy link
Contributor

@snide snide commented Sep 10, 2018

Summary

Fixes #1028
Possibly fixes #749

This adds some aria labeling to the search bar and table. Due to some funkiness with aria-live in various browsers at the moment some of it doesn't work (specifically re-reading the content after its been updated). However, this is how the aria-live spec says to do stuff.

Methods used

Searchbar now has an aria label that announces what it does and lets the user know if the content will auto update or not.

BasicTable now includes a caption which announces the amount of items present through aria-live. In combo with search bar this should read as the content changes. However, right now that isn't the case due to the bugs mentioned above. Worst case scenario is that there is a hidden table caption that does nothing at the moment.

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Live_Regions

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code review and aria-live investigations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants