Add lockOpoen icon

[ryankeairns]

Summary

Fixes #1214
Adds open version of the existing lock icon.

Checklist

• This was checked in mobile
• This was checked in IE11
• This was checked in dark mode
• Any props added have proper autodocs
• Documentation examples were added
• A changelog entry exists and is marked appropriately
• This was checked for breaking changes and labeled appropriately
• Jest tests were updated or added to match the most common scenarios
• This was checked against keyboard-only and screenreader scenarios

[snide]

Looks good. You'll need to add the typescript definition as well.

https://github.com/elastic/eui/blob/master/src/components/icon/index.d.ts

[cchaos]

Thanks for taking the initiative on this. I'm a little worried that it's not different enough from the locked icon. It's only missing 4px of a line.

Of course the obvious answer is reflect the top area horizontally, but we don't have room for that. My other (bad) idea is to rotate it slightly, but it's a semi-circle so that won't really make a difference but make the empty space larger.

¯\_(ツ)_/¯

I'll leave it up to you if you want to tweak further or just go with this.

[ryankeairns]

@cchaos That was basically my thought process and then I ended up back at this point.

If we made the box part of the icon thinner, then we could flip the hook part open. I’ll whip that up and share it here to see if that feels better.

Thanks for the feedback!

[ryankeairns]

@cchaos how does this look to you? It's only two pixels less wide on the square piece:

[cchaos]

If the hook was a bit wider I think it would be ok to also scoot the unlocked hook a little left to fit it?

[ryankeairns]

@cchaos I've updated my previous comment so we can see both versions next to one another.

The latest version feels most clear where the hook has more space between it and the box. The wider hook also looks more like the original version, so current users of the lock icon likely won't notice the change, for what that's worth.

[cchaos]

Oh, yeah, that last one looks great!

[cchaos]

I even think I like the skinnier lock better anyway.

[ryankeairns]

Cool, yeah, I like the skinnier version as well. Thanks for taking a look!