Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EuiToken enums #1301

Merged
merged 5 commits into from
Nov 8, 2018
Merged

EuiToken enums #1301

merged 5 commits into from
Nov 8, 2018

Conversation

daveyholler
Copy link
Contributor

@daveyholler daveyholler commented Nov 8, 2018 •
edited by snide
Loading

Summary

SHAPES and COLORS are now enumerated constants and exported

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

snide
snide approved these changes Nov 8, 2018
View reviewed changes
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a changelog entry, otherwise looks mergable.

src/components/token/token.js
@@ -20,6 +20,23 @@ const shapeToClassMap = {

export const SHAPES = Object.keys(shapeToClassMap);

const colorToClassMap = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor, but you could likely do this with some sort of mapping/loop. Not required though.

@chandlerprall
Copy link
Contributor

jenkins test this

@daveyholler daveyholler merged commit eb08c0c into elastic:master Nov 8, 2018
@daveyholler daveyholler deleted the token_enums branch November 8, 2018 23:48
@snide snide mentioned this pull request Nov 30, 2018
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snide snide snide approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daveyholler @chandlerprall @snide