Introducing 3 new icons. Folder Open, Folder Closed, and Crosshairs. #1350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snide
approved these changes
Dec 6, 2018
There was a problem hiding this comment.
Looks OK. You may want to double check your pixel alignment. Usually the icons end up a little soft like this when they aren't exactly on the pixel grid. I know it's hard for symmetric items in an even grid. But it's something that can be cleaned up later if you're in a hurry. A lot of times there's nothing you can do and they just end up soft.
|
Would you also mind pasting screenshots of the icons in the description of the PR? |
|
@cchaos description updated |
|
@snide I went back and forth on that a little on the crosshairs. I felt like this was the lesser of 2 evils. I've updated the folder icons though. 😄 |
snide
approved these changes
Dec 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
3 new icons. Folder Open, Folder Closed, and Crosshairs.
Checklist
This was checked in mobileThis was checked in IE11This was checked in dark modeAny props added have proper autodocsThis was checked for breaking changes and labeled appropriatelyThis was checked against keyboard-only and screenreader scenariosThis required updates to Framer X components