Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert combobox onblur pill creation in #1353 #1363

Merged
merged 3 commits into from
Dec 11, 2018
Merged

Revert combobox onblur pill creation in #1353 #1363

merged 3 commits into from
Dec 11, 2018

Conversation

snide
Copy link
Contributor

@snide snide commented Dec 11, 2018 •
edited
Loading

Summary

(#1353) introduced a bug where empty pills were being added to combo boxes on click. This reverts that change. We can do a follow up PR later to fix.

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@snide snide added the bug label Dec 11, 2018
@snide snide requested a review from cjcenizal December 11, 2018 00:34
@snide snide changed the title Revert combobox onblur pill creation from Revert combobox onblur pill creation in #1353 Dec 11, 2018
cjcenizal
cjcenizal approved these changes Dec 11, 2018
View reviewed changes
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snide snide merged commit 747c045 into elastic:master Dec 11, 2018
@snide snide deleted the revert/acblur branch December 11, 2018 00:46
@snide snide mentioned this pull request Dec 11, 2018
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcenizal cjcenizal cjcenizal approved these changes

@chandlerprall chandlerprall Awaiting requested review from chandlerprall

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snide @cjcenizal