Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix EuiSuperSelect from accessing ref when unmounted #1369

Merged
merged 2 commits into from
Dec 13, 2018

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Dec 13, 2018

Summary

The kibana GIS app places an EuiSuperSelect in a FlexItem that is unmounted when the user clicks cancel (first screen shot). If the menu is open when the cancel button is clicked, the EuiSuperSelect will be unmounted but focusSelected gets called afterward, via requestAnimationFrame, and this causes a hard crash (second screen shot, third error message). This PR just adds a check to ensure the component is still mounted before proceeding with the contents of the requestAnimationFrame callback.

screen shot 2018-12-12 at 9 46 37 pm

screen shot 2018-12-12 at 9 39 29 pm

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change LGTM

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants