Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add inputRef prop to EuiFieldNumber and allow callbacks in select inputRef #1434

Merged
merged 4 commits into from
Jan 18, 2019
Merged

Add inputRef prop to EuiFieldNumber and allow callbacks in select inputRef #1434

merged 4 commits into from
Jan 18, 2019

Conversation

Bargs
Copy link
Contributor

@Bargs Bargs commented Jan 14, 2019 •
edited
Loading

Title says it all

Summary

Summarize your PR. If it includes design elements include a screenshot or gif.

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

chandlerprall
chandlerprall suggested changes Jan 15, 2019
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a CHANGELOG entry

src/components/form/field_number/index.d.ts Outdated Show resolved Hide resolved
src/components/form/select/index.d.ts Outdated Show resolved Hide resolved
@Bargs Bargs self-assigned this Jan 15, 2019
@Bargs
Copy link
Contributor Author

Bargs commented Jan 17, 2019

@chandlerprall made the updates and added a changelog entry.

chandlerprall
chandlerprall approved these changes Jan 18, 2019
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Bargs Bargs merged commit 1a0af58 into elastic:master Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandlerprall chandlerprall chandlerprall approved these changes

Assignees

@Bargs Bargs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bargs @chandlerprall