Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow keyboard navigation of single select combobox #1619

Merged
merged 9 commits into from
Feb 28, 2019
Merged

Allow keyboard navigation of single select combobox #1619

merged 9 commits into from
Feb 28, 2019
+35 −28

Commits on Feb 27, 2019

  1. Allow keyboard navigation of single select combobox

    @chandlerprall
    chandlerprall committed Feb 27, 2019
    Configuration menu
    Copy the full SHA
    04c5e99 View commit details
    Browse the repository at this point in the history

  2. changelog

    @chandlerprall
    chandlerprall committed Feb 27, 2019
    Configuration menu
    Copy the full SHA
    40b99c0 View commit details
    Browse the repository at this point in the history

  3. Guard against invalid activeOptionIndex

    @chandlerprall
    chandlerprall committed Feb 27, 2019
    Configuration menu
    Copy the full SHA
    5d8dce6 View commit details
    Browse the repository at this point in the history

  4. Mark combobox as invalid if it loses focus and search value is presen… 

    …t; hide selected item if user has search text entered and is a singleSelection box
    @chandlerprall
    chandlerprall committed Feb 27, 2019
    Configuration menu
    Copy the full SHA
    b8dd4be View commit details
    Browse the repository at this point in the history

  5. Open combobox options list on search value change

    @chandlerprall
    chandlerprall committed Feb 27, 2019
    Configuration menu
    Copy the full SHA
    8ad73f9 View commit details
    Browse the repository at this point in the history

  6. Allow tabbing off of singleSelection combo boxes when tabbing through… 

    … form elements
    @chandlerprall
    chandlerprall committed Feb 27, 2019
    Configuration menu
    Copy the full SHA
    3d38f20 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2019

  1. Fix padding

    cchaos committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    fe68fd8 View commit details
    Browse the repository at this point in the history

  2. Fix combo box not closing when selecting an option

    @chandlerprall
    chandlerprall committed Feb 28, 2019
    Configuration menu
    Copy the full SHA
    cee925b View commit details
    Browse the repository at this point in the history

  3. Update CHANGELOG.md 

    Co-Authored-By: chandlerprall <[email protected]>
    @cchaos @chandlerprall
    cchaos and chandlerprall authored Feb 28, 2019
    Configuration menu
    Copy the full SHA
    a961127 View commit details
    Browse the repository at this point in the history