Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap lodash functions to avoid exporting lodash type defs #1723

Merged

Conversation

chandlerprall
Copy link
Contributor

@chandlerprall chandlerprall commented Mar 13, 2019

Summary

Required for elastic/kibana#32746

If eui.d.ts imports anything from lodash, TS opens lodash's index.d.ts and loads its declarations into the lodash namespace. These conflict with the lodash 3 definitions used by Kibana.

Tested this by building eui.d.ts and copying it into the Kibana above branch, then running node scripts/type_check.js

Checklist

- [ ] This was checked in mobile
- [ ] This was checked in IE11
- [ ] This was checked in dark mode
- [ ] Any props added have proper autodocs
- [ ] Documentation examples were added

  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
    - [ ] Jest tests were updated or added to match the most common scenarios
    - [ ] This was checked against keyboard-only and screenreader scenarios
    - [ ] This required updates to Framer X components

Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed with the provided testing steps

@chandlerprall chandlerprall merged commit a54ab16 into elastic:master Mar 13, 2019
@chandlerprall chandlerprall deleted the bug/restrict-lodash-types-in-euidts branch March 13, 2019 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants