Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix search box query resetting on prop updates #1823

Merged
merged 2 commits into from
Apr 11, 2019
Merged

Fix search box query resetting on prop updates #1823

merged 2 commits into from
Apr 11, 2019

Conversation

bevacqua
Copy link
Contributor

This one has been grinding our gears for as long as I can remember

Fixes https://github.com/elastic/cloud/issues/22906

chandlerprall
chandlerprall approved these changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; tested change locally to ensure docs still function as expected (controlled & uncontrolled + incremental & non-incremental)

@bevacqua bevacqua merged commit 712259d into elastic:master Apr 11, 2019
@bevacqua bevacqua deleted the fix-search-box-query-resets branch April 11, 2019 15:32
@chandlerprall chandlerprall mentioned this pull request Apr 22, 2019
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandlerprall chandlerprall chandlerprall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bevacqua @chandlerprall