Use span for loaders and set width to kibana loader #1845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryankeairns
reviewed
Apr 16, 2019
10 tasks
cchaos
suggested changes
Apr 17, 2019
cchaos
approved these changes
Apr 17, 2019
|
Hello @snide , @cchaos , @ryankeairns, The change log in master covers this change in 10.0.1, but I found it is not applied after installing. |
|
Looks like @chandlerprall got this. It was improperly labeled in the CL. |
This was referenced Apr 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replaces #1840, fixes #1834
Applies a width to the wrapping element for the Kibana loader. This also makes all of our loaders use spans instead of divs. I don't see any reason to also support divs, so this closes the PR mentioned above and removes the need for an extra prop.
Checklist
This was checked in mobileAny props added have proper autodocsThis was checked for breaking changes and labeled appropriatelyThis was checked against keyboard-only and screenreader scenariosThis required updates to Framer X components