Fix and TS EuiSteps #2186
Merged
Fix and TS EuiSteps #2186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
July 31, 2019 12:50
|
TSPR4U: cchaos#22 |
thompsongl
approved these changes
Aug 2, 2019
|
jenkins test this |
thompsongl
pushed a commit
to thompsongl/eui
that referenced
this pull request
Sep 10, 2019
* Fixed alignment of Steps if text causes wrapping * Converted EuiStep to TS * Convert EuiSubSteps to TS * Convert EuiStepHorizontal to TS * Converted EuiStepsHorizontal to TS * Converted EuiSteps to TS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed in one usage of the EuiSteps in Kibana that when the title of a step got really long, it didn't wrap very well.
Before
After
I also went ahead and updated the rest of the step components to TS.
I also fixed this quick doc error I left in
Checklist
[ ] Checked for breaking changes and labeled appropriately