Revert EuiSwitch conversions
#2255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snide
approved these changes
Aug 23, 2019
| @@ -7,6 +7,10 @@ | |||
| - Fixed `EuiSuperDatePicker` to update `asyncInterval.isStopped` on a `isPaused` prop change. ([#2250](https://github.com/elastic/eui/pull/2250)) | |||
| - Converted table, popover, buttons, pagination, outside click detector, focus trap, context menu, and panel to TypeScript ([#2212](https://github.com/elastic/eui/pull/2212)) | |||
|
|
|||
| **Reverts** | |||
There was a problem hiding this comment.
Should the warning notes be in here for the previous releases or will you just do that when you create the next one?
There was a problem hiding this comment.
Next one. I'll add notes once there's a real version that can be pointed to.
You'll be able to see them in master, though, after that release gets published. There'll be a manual CL update to document the out-of-order release
thompsongl
added a commit
that referenced
this pull request
Aug 23, 2019
thompsongl
added a commit
to thompsongl/eui
that referenced
this pull request
Sep 10, 2019
* Revert "Convert `EuiSwitch` to TS (elastic#2243)" This reverts commit 39dbcf6. * Revert "Aligning switch semantics with aria role (elastic#2193)" This reverts commit 76e58de. * CL
This was referenced Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reverts #2193 and #2243.
Nothing wrong with the changes themselves, but we have more pressing changes to make in Kibana that will be jeopardized by the updates required to
EuiSwitchconsumers.The problem we see in Kibana is specific to Angular form $dirty checking. Moving from
input[type=checkbox]tobutton[role=switch]was (correctly) done for a11y, but Angular does not flip dirty state forbuttonelements (or for hacking in aninput[type=hidden]. The Visualize app relies heavily on this Angular mechanism to enable refresh and save capabilities, and has functional tests that match those expectations. The second TS commit reversion is simply for completeness.This merge commit will be cherry-picked for a release outside the standard master process.
Checklist
- [ ] Checked in dark mode- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes