Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EuiDataGrid add column sorting #2278

Merged
merged 9 commits into from
Sep 10, 2019
Merged

EuiDataGrid add column sorting #2278

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ebf0e5e
API interface for providing column sort order, callback to allow exte…
chandlerprall Aug 29, 2019
51a7a14
EuiDataGrid renders content into memory, sorts on it
chandlerprall Aug 29, 2019
93e6726
Added tests for EuiDataGrid sorting
chandlerprall Aug 30, 2019
96521f0
Added aria-sort value to a singly-sorted column header
chandlerprall Aug 30, 2019
79ca2b5
small cleanup
chandlerprall Aug 30, 2019
b4f50f8
Merge remote-tracking branch 'upstream/feature/euidatagrid' into feea…
snide Sep 5, 2019
e4d54c5
add tests back in, though they are still broken
snide Sep 5, 2019
8b15c35
Clean up some keyboard navigation issues
chandlerprall Sep 6, 2019
dedd65e
Fix column sorting & update snapshots
chandlerprall Sep 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion src-docs/src/views/datagrid/datagrid.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,13 +77,31 @@ export default class DataGridContainer extends Component {
super(props);

this.state = {
sortingColumns: [],
data,
pagination: {
pageIndex: 0,
pageSize: 50,
},
};
}

setSorting = sortingColumns => {
const sortedData = [...data].sort((a, b) => {
for (let i = 0; i < sortingColumns.length; i++) {
const column = sortingColumns[i];
const aValue = a[column.id];
const bValue = b[column.id];

if (aValue < bValue) return column.direction === 'asc' ? -1 : 1;
if (aValue > bValue) return column.direction === 'asc' ? 1 : -1;
}

return 0;
});
this.setState({ sortingColumns, data: sortedData });
};

setPageIndex = pageIndex =>
this.setState(({ pagination }) => ({
pagination: { ...pagination, pageIndex },
Expand All @@ -102,14 +120,15 @@ export default class DataGridContainer extends Component {
);

render() {
const { pagination } = this.state;
const { data, pagination, sortingColumns } = this.state;

return (
<EuiDataGrid
aria-label="Top EUI contributors"
columns={columns}
rowCount={data.length}
renderCellValue={({ rowIndex, columnId }) => data[rowIndex][columnId]}
sorting={{ columns: sortingColumns, onSort: this.setSorting }}
pagination={{
...pagination,
pageSizeOptions: [5, 10, 25],
Expand Down
Loading