Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release scripts to push to upstream instead of origin. #233

Merged
merged 1 commit into from
Dec 20, 2017

Conversation

cjcenizal
Copy link
Contributor

I think our common set up is to fork a repo and have the origin remote pointing to the fork and upstream pointing to the original. The way the script is currently written results in a divergence between the fork and the original because the new release only gets pushed to the fork, but it should be pushed to the original.

Copy link
Contributor

@pugnascotia pugnascotia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjcenizal cjcenizal merged commit 3f866df into elastic:master Dec 20, 2017
@cjcenizal cjcenizal deleted the scripts/push-to-upstream branch December 20, 2017 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants