Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added focus state to EuiListGroupItem #2406

Merged
merged 4 commits into from
Oct 10, 2019

Conversation

andreadelrio
Copy link
Contributor

Summary

Added focus state to EuiListGroupItem and updated some of the docs examples.

a-ezgif com-video-to-gif

Covers #2266

Checklist

- [ ] Checked in dark mode
- [ ] Checked in mobile
- [ ] Checked in IE11 and Firefox
- [ ] Props have proper autodocs
- [ ] Added documentation examples
- [ ] Added or updated jest tests
- [ ] Checked for breaking changes and labeled appropriately
- [ ] Checked for accessibility including keyboard-only and screenreader modes

  • A changelog entry exists and is marked appropriately

@andreadelrio andreadelrio changed the title updated docs and added focus state to button Added focus state to EuiListGroupItem Oct 8, 2019
@snide snide requested a review from ryankeairns October 8, 2019 18:47
Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there!

One slight regression... an underline now appears when you hover the disabled links in the first two examples on the List Group docs page:

Screenshot 2019-10-09 15 42 31

Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@andreadelrio andreadelrio merged commit 9985aad into elastic:master Oct 10, 2019
snide pushed a commit to snide/eui that referenced this pull request Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants