Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EuiSuggest: converted to Typescript #2692

Merged
merged 7 commits into from
Dec 30, 2019
Merged

EuiSuggest: converted to Typescript #2692

merged 7 commits into from
Dec 30, 2019

Conversation

ffknob
Copy link
Contributor

@ffknob ffknob commented Dec 18, 2019

Summary

Closes #2644

Converted EuiSuggest to Typescript.

Checklist

  • Check against all themes for compatability in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

This was referenced Dec 18, 2019
Open
Closed
@ffknob
Copy link
Contributor Author

ffknob commented Dec 18, 2019

This one demanded a lot of effort... Although it passed tests, I'm sure it needs some polishing

chandlerprall
chandlerprall suggested changes Dec 27, 2019
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments/requests, but overall this looks great. Definitely like the Component -> FunctionComponent conversion!

src/components/suggest/suggest.tsx Outdated Show resolved Hide resolved
src/components/suggest/suggest.tsx Outdated Show resolved Hide resolved
src/components/suggest/suggest.tsx Outdated Show resolved Hide resolved
src/components/suggest/suggest.tsx Outdated Show resolved Hide resolved
src/components/suggest/suggest_input.tsx Outdated Show resolved Hide resolved
src/components/suggest/suggest_item.tsx Outdated Show resolved Hide resolved
src/components/suggest/suggest_item.tsx Outdated Show resolved Hide resolved
src/components/suggest/suggest_item.tsx Outdated Show resolved Hide resolved
src/components/suggest/suggest_item.tsx Outdated Show resolved Hide resolved
src/components/suggest/suggest_item.tsx Show resolved Hide resolved
@chandlerprall
Copy link
Contributor

Oh, this also needs to export the Eui*Props types from src/components/suggest/index.ts

@ffknob
Copy link
Contributor Author

ffknob commented Dec 27, 2019

Don't know if I got it all right... if you could take a new look I'd appreciate

chandlerprall
chandlerprall suggested changes Dec 27, 2019
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look correct - one more request I just saw/added and a previous one was missed, as GitHub's interface hid it behind a "load more conversations" button #2692 (comment)

src/components/suggest/suggest_item.tsx Outdated Show resolved Hide resolved
chandlerprall
chandlerprall suggested changes Dec 30, 2019
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last ask, then this should be good to go

src/components/suggest/suggest_item.tsx Outdated Show resolved Hide resolved
@chandlerprall
Copy link
Contributor

jenkins test this

chandlerprall
chandlerprall approved these changes Dec 30, 2019
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM; pulled & tested locally

@chandlerprall chandlerprall merged commit 772d2a8 into elastic:master Dec 30, 2019
@chandlerprall chandlerprall mentioned this pull request Jan 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandlerprall chandlerprall chandlerprall approved these changes

Assignees
No one assigned
Labels
typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EuiSuggest needs to be converted to TS
4 participants
@ffknob @elasticmachine @chandlerprall @snide