Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes : #2925 Now euiTitle renders classes of children too #2926

Merged
merged 5 commits into from
Feb 26, 2020

Conversation

anishagg17
Copy link
Contributor

@anishagg17 anishagg17 commented Feb 25, 2020

Summary

Fixes : #2925
Now euiTitle renders classNames of children too

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@anishagg17 anishagg17 changed the title Fixes : #2925 euiTitle Fixes : #2925 Now euiTitle renders classes of children too Feb 25, 2020
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Let's also add a new snapshot test showing this use case.

src/components/title/title.tsx Outdated Show resolved Hide resolved
@anishagg17
Copy link
Contributor Author

@thompsongl changes have been made

Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my other comment also:

Let's also add a new snapshot test showing this use case.

@anishagg17
Copy link
Contributor Author

okay

@anishagg17
Copy link
Contributor Author

@thompsongl Test has been added

src/components/title/title.test.tsx Outdated Show resolved Hide resolved
@thompsongl
Copy link
Contributor

jenkins test this

CHANGELOG.md Outdated Show resolved Hide resolved
Co-Authored-By: Caroline Horn <[email protected]>
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 🎉

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_2926/

@thompsongl
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_2926/

Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snaphots are outdated (from the name change). Need to update them locally

@anishagg17
Copy link
Contributor Author

@thompsongl I have updated SnapShots

@thompsongl
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_2926/

@thompsongl thompsongl merged commit dc199cf into elastic:master Feb 26, 2020
thompsongl added a commit that referenced this pull request Feb 26, 2020
@anishagg17 anishagg17 deleted the euiTitle branch February 26, 2020 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EuiTitle wipes out className of cloned child
4 participants