-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes : #2925 Now euiTitle renders classes of children too #2926
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Let's also add a new snapshot test showing this use case.
@thompsongl changes have been made |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my other comment also:
Let's also add a new snapshot test showing this use case.
okay |
@thompsongl Test has been added |
Co-Authored-By: Greg Thompson <[email protected]>
jenkins test this |
Co-Authored-By: Caroline Horn <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks 🎉
Preview documentation changes for this PR: https://eui.elastic.co/pr_2926/ |
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_2926/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Snaphots are outdated (from the name change). Need to update them locally
@thompsongl I have updated SnapShots |
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_2926/ |
Summary
Fixes : #2925
Now euiTitle renders classNames of children too
Checklist