Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed data grid break on invalid schema #2955

Merged
merged 3 commits into from
Mar 2, 2020

Conversation

ashikmeerankutty
Copy link
Contributor

@ashikmeerankutty ashikmeerankutty commented Mar 1, 2020

Summary

Fixes #2949
Fixed Data grid break on invalid schema

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, though I've requested a fix for the isSortable logic that I got wrong.

src/components/datagrid/column_sorting.tsx Outdated Show resolved Hide resolved
@ashikmeerankutty
Copy link
Contributor Author

@chandlerprall Changes updated. Can you please review it?

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! Pulled & tested locally

Thanks again @ashikmeerankutty

@chandlerprall chandlerprall merged commit 72ee607 into elastic:master Mar 2, 2020
@ashikmeerankutty ashikmeerankutty deleted the datagrid-fixes branch April 15, 2020 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataGrid shouldn't fall to pieces when an invalid schema is provided
3 participants