Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove syncify #306

Merged
merged 1 commit into from
Jan 15, 2018
Merged

Remove syncify #306

merged 1 commit into from
Jan 15, 2018

Conversation

kimjoar
Copy link
Contributor

@kimjoar kimjoar commented Jan 15, 2018

It's no longer needed as of Jest 22, see jestjs/jest#4884,

await expect(myPromise).rejects.toThrow('failure');

x-pack is already on Jest 22, while there's an open PR for Kibana: elastic/kibana#16041

@kimjoar kimjoar mentioned this pull request Jan 15, 2018
Closed
bevacqua
bevacqua approved these changes Jan 15, 2018
View reviewed changes
Copy link
Contributor

@bevacqua bevacqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kimjoar
Copy link
Contributor Author

kimjoar commented Jan 15, 2018

Merging this as it doesn't seem to be used anywhere yet.

@kimjoar kimjoar merged commit 83092ef into elastic:master Jan 15, 2018
@kimjoar
Copy link
Contributor Author

kimjoar commented Jan 15, 2018

cc @chrisronline

@kimjoar kimjoar mentioned this pull request Jan 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bevacqua bevacqua bevacqua approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kimjoar @bevacqua