Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EuiIcon TypeScript definitions #323

Merged
merged 2 commits into from
Jan 22, 2018
Merged

Update EuiIcon TypeScript definitions #323

merged 2 commits into from
Jan 22, 2018

Conversation

weltenwort
Copy link
Member

This adds new icon types to the type definitions of EuiIcon.

@weltenwort weltenwort self-assigned this Jan 19, 2018
cjcenizal
cjcenizal approved these changes Jan 19, 2018
View reviewed changes
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@uboness
Copy link
Contributor

uboness commented Jan 19, 2018

LGTM

@weltenwort weltenwort merged commit a9ba5a8 into elastic:master Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uboness uboness uboness approved these changes

@cjcenizal cjcenizal cjcenizal approved these changes

Assignees

@weltenwort weltenwort

Labels
typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@weltenwort @uboness @cjcenizal @snide