-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Converted form control component examples to functional component #3242
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3242/ |
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3242/ |
PR #3129 is working on shifting the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @walter-ind! 🎉
I tested the Demo and Demo JS tabs and all of them look good!
There's no need for the PR #3129 because I fixed the issue with the commit 8e37b86. We can't merge issues with errors.
But you have only changed the components inside form_controls to htmlIdGenerator where as there are other components as well which are using them |
Yes, @NightWing1998 you're right. Your PR fixes much more components. When I said there's no need for PR #3129 I was trying to say that to merge this PR (#3242) we don't need to wait on #3129. 🙂 |
Ohh my bad😅 |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3242/ |
Summary
Progress on #3150