[EuiCollapsibleNavGroup] Fix titleSize prop types and added iconProps prop
#3365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3365/ |
miukimiu
approved these changes
Apr 23, 2020
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3365/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3365/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes usage of
<Omit>as a prop type instead of prop valueBefore
I was trying to disallow the
landmoptions fromtitleSize, but it was still being allowed:After
Using
<Exclude>instead of<Omit>fixed the issueAlso, I added a
iconPropsprop to allow extending of the EuiIcon propsLike for adding
data-test-subjto the rendered icon.CONSUMING.md
I know this isn't really related, but I added a small section to this wiki page to explain how a consumer should handle customizing the styles of EUI components via
className.Checklist
[ ] Check against all themes for compatibility in both light and dark modes[ ] Checked in mobile[ ] Checked in IE11 and Firefox[ ] Added documentation examples[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes