-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed double search issue with [EuiFieldSearch] #3425
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3425/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this in IE11 and latest FF, Chrome, Safari, and Edge (for mac). Looks good, other than one additional edge case.
jenkins test this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Tested locally across our supported browsers with incremental mode enabled and disabled, everything calls the onSearch callback once as expected/desired. Will merge on passing CI.
Preview documentation changes for this PR: https://eui.elastic.co/pr_3425/ |
I think this test is not related to current changes in any way |
That one's known to be flaky, jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3425/ |
Summary
Fixes: #3420
I noticed that
onSearch
was called twice because of its binding with the input element duringcomponentDidMount
function as well asonKeyUp
function.Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes