Correct IconControlProps to include an onClick definition #3581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cchaos
reviewed
Jun 9, 2020
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3581/ |
thompsongl
approved these changes
Jun 9, 2020
There was a problem hiding this comment.
LGTM
Verified by adding some more controls to the .test.tsx file
{
controlType: 'icon',
id: 'sample_icon',
iconType: 'alert',
color: 'danger',
'aria-label': 'Sample Icon',
onClick: () => {},
},
{
controlType: 'icon',
id: 'sample_icon',
iconType: 'alert',
color: 'danger',
'aria-label': 'Sample Icon',
href: '#danger',
},
{
controlType: 'icon',
id: 'sample_icon',
iconType: 'alert',
color: 'danger',
'aria-label': 'Sample Icon',
onClick: () => {},
href: '#danger',
},
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3581/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3581/ |
phyolim
pushed a commit
to phyolim/eui
that referenced
this pull request
Jun 11, 2020
* Correct IconControlProps to include an onClick definition * changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3523
Added the
onClickvalue toIconControlProps, tested by copying src-docs/src/views/control_bar/control_bar.js'scodeControlsinto control_bar.tsx and typing asControl[].Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Added documentation- [ ] Checked Code Sandbox works for the any docs examples- [ ] Added or updated jest tests- [ ] Checked for accessibility including keyboard-only and screenreader modes