Fix EuiTableOfRecords selection bug when selected items are deleted #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
force-pushed
the
bug/table-all-selected-checkbox
branch
from
66ec432
to
6345ad8
Compare
uboness
reviewed
Feb 5, 2018
| onDataCriteriaChange(criteria) { | ||
| this.setState(this.computeTableState(criteria)); | ||
| } | ||
|
|
||
| deletePerson(personToDelete) { | ||
| const i = people.findIndex((person) => person.id === personToDelete.id); | ||
| if (i >= 0) { | ||
| if (i !== -1) { |
There was a problem hiding this comment.
while both work, i >= 0 makes more sense (or i > -1 also works)
| @@ -235,6 +235,25 @@ export class EuiTableOfRecords extends React.Component { | |||
| this.setState({ hoverRecordId: null }); | |||
| } | |||
|
|
|||
| componentWillReceiveProps(nextProps) { | |||
| // Don't call changeSelection here or else we can get into an infinite loop: | |||
| // changeSelection calls owner -> owner sets its state -> we receive new props -> ad infinitum | |||
There was a problem hiding this comment.
what's "owner"... I think the reason for this is that the changeSelection also calls onSelectionChange if one is provided... and that one may change the props.... I think we should be clear about it
| headers.push( | ||
| <EuiTableHeaderCellCheckbox key="_selection_column_h" width="24px"> | ||
| <EuiCheckbox | ||
| id="_selection_column-checkbox" | ||
| type="inList" | ||
| checked={checked} | ||
| onChange={onChange} | ||
| data-test-subj="checkboxSelectAll" |
| @@ -479,13 +503,13 @@ export class EuiTableOfRecords extends React.Component { | |||
| checked={checked} | |||
| onChange={onChange} | |||
| title={title} | |||
| data-test-subj={`checkboxSelectRow-${recordId}`} | |||
cjcenizal
force-pushed
the
bug/table-all-selected-checkbox
branch
from
55d770f
to
e551b90
Compare
cjcenizal
force-pushed
the
bug/table-all-selected-checkbox
branch
from
e551b90
to
e34e154
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed two bugs: