Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ML icon updates #3931

Merged
merged 8 commits into from
Aug 19, 2020
Merged

ML icon updates #3931

merged 8 commits into from
Aug 19, 2020

Conversation

mdefazio
Copy link
Contributor

@mdefazio mdefazio commented Aug 18, 2020 •
edited
Loading

Summary

Adds new icons for the following ML needs as requested in #3779:

  • Outlier detection
  • Classification
  • Regression

The app search and workplace search icons were also caught by linter—removed the fill-mode from svg code.

Light mode:
image

Dark mode:
image

Amsterdam Light:
image

Amsterdam Dark:
image

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • [ ] Props have proper autodocs
  • [ ] Added documentation
  • [ ] Checked Code Sandbox works for the any docs examples
  • [ ] Added or updated jest tests
  • [ ] Checked for breaking changes and labeled appropriately
  • [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@mdefazio mdefazio added the icons label Aug 18, 2020
@mdefazio
Copy link
Contributor Author

mdefazio commented Aug 18, 2020 •
edited by alvarezmelissa87
Loading

Not sure if the should be named with the create prefix. Can you advise if this makes sense please @alvarezmelissa87 ?

@mdefazio - I don't think it's necessary as we will not only be using them in the creation wizard. Just the job type name should be fine. (e.g. classificationJob)

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3931/

@cchaos
Copy link
Contributor

cchaos commented Aug 18, 2020

Chromium fail, retest

@cchaos
Copy link
Contributor

cchaos commented Aug 18, 2020

retest

cchaos
cchaos reviewed Aug 18, 2020
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you paste some screenshots of the artboards so we can see the pixel grid as well?

src/components/icon/icon.tsx Outdated Show resolved Hide resolved
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3931/

@mdefazio
Copy link
Contributor Author

Can you paste some screenshots of the artboards so we can see the pixel grid as well?

Updated grid for all icons
image

@mdefazio mdefazio removed the request for review from chandlerprall August 19, 2020 16:35
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3931/

@mdefazio
Copy link
Contributor Author

Workplace and App search icons updated:
image
image

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3931/

cchaos
cchaos approved these changes Aug 19, 2020
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM with a comment about the changelog entry.

CHANGELOG.md Outdated Show resolved Hide resolved
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3931/

@mdefazio
Copy link
Contributor Author

retest

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3931/

@mdefazio mdefazio merged commit 2420cc9 into elastic:master Aug 19, 2020
@mdefazio mdefazio mentioned this pull request Aug 20, 2020
Closed
snide pushed a commit to snide/eui that referenced this pull request Aug 20, 2020
@mdefazio @snide
ML icon updates (elastic#3931)
6efa5b4 
* Add new ML icons.  Prettier updates on app search icons.

* Update alignment in all ML icons

* Update app search and workplace search icons

* Update changelog

* Fix changelog entry

* Fix changelog entry
@thompsongl thompsongl mentioned this pull request Sep 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos approved these changes

Assignees
No one assigned
Labels
icons
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdefazio @kibanamachine @cchaos