Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiContextMenu] Add line separator as menu item #4018

Merged
merged 14 commits into from
Sep 16, 2020
Merged

[EuiContextMenu] Add line separator as menu item #4018

merged 14 commits into from
Sep 16, 2020

Conversation

streamich
Copy link
Contributor

@streamich streamich commented Sep 8, 2020 •
edited
Loading

Summary

This is a Proof-of-Concept for line separator that we need for elastic/kibana#66051

image

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • [ ] Props have proper autodocs
  • Added documentation
  • [ ] Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • [ ] Checked for breaking changes and labeled appropriately
  • [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@streamich streamich mentioned this pull request Sep 8, 2020
Merged
2 tasks
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4018/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4018/

@cchaos
Copy link
Contributor

cchaos commented Sep 10, 2020

Jenkins, test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4018/

cchaos
cchaos suggested changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @streamich ! I think this looks pretty good. I'm noticing that panel props aren't very helpful in our docs at the moment so we'll want to directly add a line in our docs about how to add this separator. Can you add something to the Using panels with mixed items & content section of context_menu_example.js?

Also, I'll update the checklist in the summary, the main outstanding one being a Changelog entry.

src/components/context_menu/context_menu.tsx Outdated Show resolved Hide resolved
@cchaos cchaos changed the title PoC for menu item line separator [EuiContextMenu] Add line separator as menu item Sep 10, 2020
@streamich
Copy link
Contributor Author

Thanks @cchaos for the review! I've updated the docs and added a line to CHANGELOG.

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4018/

@chandlerprall
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4018/

cchaos
cchaos approved these changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling the documentation! Just a couple suggestions on wording. But overall design and docs LGTM 👍

I'll pass it to @chandlerprall for the code side.

src-docs/src/views/context_menu/context_menu_example.js Outdated Show resolved Hide resolved
src-docs/src/views/context_menu/context_menu_example.js Outdated Show resolved Hide resolved
chandlerprall
chandlerprall suggested changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last request.

Additionally, I pushed a small refactor that is tangentially related: now that EuiHorizontalRuleProps is being exported as an externally accessible interface, this ensures it contains all of the applicable props that a usage could specify.

src/components/context_menu/context_menu.tsx Outdated Show resolved Hide resolved
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4018/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4018/

chandlerprall
chandlerprall approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! Pulled & tested types locally - feel free to merge, @streamich

@streamich streamich merged commit ee78ad0 into master Sep 16, 2020
@streamich streamich deleted the menu-line branch September 16, 2020 10:53
@streamich
Copy link
Contributor Author

streamich commented Sep 17, 2020 •
edited
Loading

@chandlerprall @cchaos Wanted to ask you, do you think this change will make Kibana 7.10, so we can actually make use of it already in 7.10?

@thompsongl thompsongl mentioned this pull request Sep 17, 2020
Merged
@streamich
Copy link
Contributor Author

OK, I see it was merged.

@chandlerprall
Copy link
Contributor

Yep! We update Kibana's master branch to the new EUI release, and then backport that to the 7.x branch - this should certainly land in time to be used in 7.10

@chandlerprall chandlerprall mentioned this pull request Sep 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos approved these changes

@chandlerprall chandlerprall chandlerprall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@streamich @kibanamachine @cchaos @chandlerprall