Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amsterdam toast update #4076

Merged
merged 6 commits into from
Sep 24, 2020
Merged

Conversation

hbharding
Copy link
Contributor

@hbharding hbharding commented Sep 24, 2020

Summary

Updates Amsterdam theme for EuiToasts:

  • Titles are now bold
  • Removed 1px light grey border surrounding toast
  • Increased vibrancy of top-border color
  • Reduced spacing between title and content from 12px to 8px, which is consistent with EuiText's 8px spacing after headers. This change applies to both our existing base theme and Amsterdam.

Screenshot After:

image

Screenshot Before:

image

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • [ ] Checked in mobile
  • [ ] Checked in Chrome, Safari, Edge, and Firefox
  • [ ] Props have proper autodocs
  • [ ] Added documentation
  • [ ] Checked Code Sandbox works for the any docs examples
  • [ ] Added or updated jest tests
  • [ ] Checked for breaking changes and labeled appropriately
  • [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4076/

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially I thought some more of these changes could be added to the default theme as well, but I think ultimately we should continue to set apart Amsterdam and not just blanket updates. So 👍 LGTM, with just a comment about the CL.

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Caroline Horn <[email protected]>
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4076/

@hbharding hbharding merged commit 8f21ffd into elastic:master Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants