Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiIcon] Add plus and minus glyphs #4111

Merged
merged 6 commits into from
Oct 7, 2020
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
- Added `key` to `EuiComboBoxOptionOption` to allow duplicate labels ([#4048](https://github.com/elastic/eui/pull/4048))
- Changed `EuiIcon` test mock to render as `span` instead of `div` ([#4099](https://github.com/elastic/eui/pull/4099))
- Added `scripts/docker-puppeteer` as the new home for test-related Docker images ([#4062](https://github.com/elastic/eui/pull/4062))
- Added `plus` and `minus` glyphs to `EuiIcon` ([#4111](https://github.com/elastic/eui/pull/4111))

**Bug fixes**

Expand Down
2 changes: 2 additions & 0 deletions src-docs/src/views/icon/icons.js
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ export const iconTypes = [
'menuLeft',
'menuRight',
'minimize',
'minus',
'minusInCircle',
'minusInCircleFilled',
'moon',
Expand All @@ -155,6 +156,7 @@ export const iconTypes = [
'pin',
'pinFilled',
'play',
'plus',
'plusInCircle',
'plusInCircleFilled',
'popout',
Expand Down
38 changes: 38 additions & 0 deletions src/components/icon/__snapshots__/icon.test.tsx.snap
Original file line number Diff line number Diff line change
Expand Up @@ -6179,6 +6179,27 @@ exports[`EuiIcon props type minimize is rendered 1`] = `
</svg>
`;

exports[`EuiIcon props type minus is rendered 1`] = `
<svg
aria-hidden="true"
class="euiIcon euiIcon--medium euiIcon-isLoaded"
focusable="false"
height="16"
role="img"
viewBox="0 0 16 16"
width="16"
xmlns="http://www.w3.org/2000/svg"
>
<rect
height="1.5"
rx="0.5"
width="10"
x="3"
y="7.25"
/>
</svg>
`;

exports[`EuiIcon props type minusInCircle is rendered 1`] = `
<svg
aria-hidden="true"
Expand Down Expand Up @@ -6600,6 +6621,23 @@ exports[`EuiIcon props type play is rendered 1`] = `
</svg>
`;

exports[`EuiIcon props type plus is rendered 1`] = `
<svg
aria-hidden="true"
class="euiIcon euiIcon--medium euiIcon-isLoaded"
focusable="false"
height="16"
role="img"
viewBox="0 0 16 16"
width="16"
xmlns="http://www.w3.org/2000/svg"
>
<path
d="M8.25 3a.5.5 0 01.5.5v3.75h3.75a.5.5 0 01.5.5v.5a.5.5 0 01-.5.5H8.75v3.75a.5.5 0 01-.5.5h-.5a.5.5 0 01-.5-.5V8.75H3.5a.5.5 0 01-.5-.5v-.5a.5.5 0 01.5-.5h3.75V3.5a.5.5 0 01.5-.5h.5z"
/>
</svg>
`;

exports[`EuiIcon props type plusInCircle is rendered 1`] = `
<svg
aria-hidden="true"
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/accessibility.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAccessibility = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/aggregate.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAggregate = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/alert.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAlert = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/analyze_event.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAnalyzeEvent = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/annotation.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAnnotation = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/apm_trace.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconApmTrace = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/app_add_data.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAppAddData = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/app_advanced_settings.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAppAdvancedSettings = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/app_apm.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAppApm = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/app_app_search.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAppAppSearch = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/app_auditbeat.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAppAuditbeat = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/app_canvas.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/components/icon/assets/app_code.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAppCode = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/app_console.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAppConsole = ({ title, titleId, ...props }) => (
<svg
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAppCrossClusterReplication = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/app_dashboard.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAppDashboard = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/app_devtools.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAppDevtools = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/app_discover.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAppDiscover = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/app_ems.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAppEms = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/app_filebeat.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAppFilebeat = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/app_gis.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAppGis = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/app_graph.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAppGraph = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/app_grok.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAppGrok = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/app_heartbeat.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAppHeartbeat = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/app_index_management.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAppIndexManagement = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/app_index_pattern.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAppIndexPattern = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/app_index_rollup.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAppIndexRollup = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/app_lens.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAppLens = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/app_logs.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAppLogs = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/app_management.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAppManagement = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/app_metricbeat.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAppMetricbeat = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/app_metrics.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAppMetrics = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/app_ml.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAppMl = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/app_monitoring.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAppMonitoring = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/app_notebook.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAppNotebook = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/app_packetbeat.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAppPacketbeat = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/app_pipeline.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAppPipeline = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/app_recently_viewed.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAppRecentlyViewed = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/app_reporting.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAppReporting = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/app_saved_objects.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAppSavedObjects = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/app_search_profiler.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAppSearchProfiler = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/app_security.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAppSecurity = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/app_security_analytics.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAppSecurityAnalytics = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/app_spaces.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAppSpaces = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/app_sql.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAppSql = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/app_timelion.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAppTimelion = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/app_upgrade_assistant.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAppUpgradeAssistant = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/app_uptime.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAppUptime = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/app_users_roles.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAppUsersRoles = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/app_visualize.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAppVisualize = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/app_watches.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAppWatches = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/app_workplace_search.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconAppWorkplaceSearch = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/apps.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconApps = ({ title, titleId, ...props }) => (
<svg
Expand Down
2 changes: 1 addition & 1 deletion src/components/icon/assets/arrow_down.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import * as React from 'react';

const EuiIconArrowDown = ({ title, titleId, ...props }) => (
<svg
Expand Down
Loading