-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiSelectable] call searchProps functions on search/change #4153
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
💚 CLA has been signed |
👋 Welcome @krosenk729 ! Would you please sign the CLA linked below. Be sure to use the same email address linked to your Github account. I'll get our CI (Jenkins) started for you which will run our tests and get a preview built. |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4153/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main changes look good; thank you!
Just need some adjustments to the complex destructuring bit. You'll also want to add a changelog entry under the Bug fixes
section (use previous entries as examples).
Hey @krosenk729, checking in to see if you still plan to make additional changes to this PR. |
Thanks for the ping @thompsongl and sorry for the delay. changes have been made! |
Thanks, @krosenk729! |
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4153/ |
Summary
Resolves
onChange
issue in searchProps as mentioned in #4132Checklist