Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiSelectable] call searchProps functions on search/change #4153

Merged
merged 2 commits into from
Nov 9, 2020
Merged

[EuiSelectable] call searchProps functions on search/change #4153

merged 2 commits into from
Nov 9, 2020

Conversation

krosenk729
Copy link
Contributor

Summary

Resolves onChange issue in searchProps as mentioned in #4132

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs
  • Added documentation
  • Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

cla-checker-service bot commented Oct 18, 2020

💚 CLA has been signed

@cchaos
Copy link
Contributor

cchaos commented Oct 19, 2020

👋 Welcome @krosenk729 ! Would you please sign the CLA linked below. Be sure to use the same email address linked to your Github account. I'll get our CI (Jenkins) started for you which will run our tests and get a preview built.
Jenkins, test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4153/

Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main changes look good; thank you!

Just need some adjustments to the complex destructuring bit. You'll also want to add a changelog entry under the Bug fixes section (use previous entries as examples).

src/components/selectable/selectable.tsx Outdated Show resolved Hide resolved
@thompsongl thompsongl changed the title calling search props functions on search/change [EuiSelectable] call searchProps functions on search/change Oct 20, 2020
@thompsongl
Copy link
Contributor

Hey @krosenk729, checking in to see if you still plan to make additional changes to this PR.
If so, great! If not, we're more than happy to take it over and make the updates.
Thanks for the help so far!

@krosenk729
Copy link
Contributor Author

Thanks for the ping @thompsongl and sorry for the delay. changes have been made!

@thompsongl
Copy link
Contributor

Thanks, @krosenk729!

@thompsongl
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4153/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants