[EuiDataGrid] use schema sorting labels instead of placeholder value #4199
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Came up again in #4197 but also reported in slack last week, the recently added column actions used placeholder copy for sort text instead of using the column schema's labels.
I opted to nest the existing i18n'd labels (
A-Z
,High-Low
) into a new i18n token which prependsSort
. I think this combines the best of re-usability while retaining flexibility for downstream consuming applications. I confirmed these overrides work as expected (see below).Before
After
Localized schema labels
Localized schema + sort labels
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in Chrome, Safari, Edge, and Firefox- [ ] Props have proper autodocs- [ ] Added documentation- [ ] Checked Code Sandbox works for the any docs examples- [ ] Checked for accessibility including keyboard-only and screenreader modes