Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add floats to EuiImage #4209

Merged
merged 3 commits into from
Nov 2, 2020
Merged

Add floats to EuiImage #4209

merged 3 commits into from
Nov 2, 2020

Conversation

snide
Copy link
Contributor

@snide snide commented Oct 30, 2020 •
edited
Loading

Summary

Adds props for float and margin to EuiImage. This is needed for long-form text content, like documentation where an image compliments the text in an article format.

image

TODO:

  • Drop floats on mobile

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs
  • Added documentation
  • Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4209/

@snide snide requested a review from miukimiu October 30, 2020 21:52
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4209/

miukimiu
miukimiu approved these changes Nov 2, 2020
View reviewed changes
Copy link
Contributor

@miukimiu miukimiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. 🎉

I tested it locally and the float and margin seem to work as expected.

I just have a suggestion. I think the margin prop might be used out of context and for this reason we should probably rename it.

src/components/image/image.tsx Show resolved Hide resolved
@snide snide merged commit fcda1ac into elastic:master Nov 2, 2020
@snide snide deleted the image/floats branch November 2, 2020 22:57
cchaos pushed a commit to andreadelrio/eui that referenced this pull request Nov 4, 2020
@snide
Add floats to EuiImage (elastic#4209)
2cd84ee 
Adds props for `float` and `margin` to `EuiImage`. This is needed for long-form text content, like documentation where an image compliments the text in an article format.
@thompsongl thompsongl mentioned this pull request Nov 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos left review comments

@miukimiu miukimiu miukimiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@snide @kibanamachine @cchaos @miukimiu