[EuiButtonGroup] Fix initial focus when in a popover #4288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By removing the `transition: all` on the `.euiButtonGroup__buttons` selector Also added an example to the compressed forms page.
|
Thanks for investigating and finding the root cause @chandlerprall !! |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4288/ |
chandlerprall
approved these changes
Nov 19, 2020
added 2 commits
November 19, 2020 14:43
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4288/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By removing the
transition: allon the.euiButtonGroup__buttonsselector. This was safe to remove because no interaction states were directly applied to this selector. It was probably leftover from before the a11y fix.Also added an example to the compressed forms page.
Fixes #4266
Before
After
Checklist
[ ] Checked in mobile[ ] Props have proper autodocs[ ] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately