[EuiMarkdownEditor] Changed the return type of getDefaultEuiMarkdownUiPlugins #4567
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
hetanthakkar
changed the title
|
should add a bugfix entry to CHANGELOG.md |
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4567/ |
|
I am new to open source. @thompsongl @akashgp09 Could you please let me know what went wong. |
@hetanthakkar1 Just some CI troubles lately. Nothing related to your PR. jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4567/ |
|
@thompsongl okay thanks |
There was a problem hiding this comment.
This appears to solve the push type problem. Thanks!
Just need to add a changelog entry
|
@thompsongl @akashgp09 thanks for review. I have added a changelog entry. |
|
I have added a changelog entry.Thanks for correcting me @cchaos. I mistakenly made a new PR for this CHANGELOG instead of commit. Will take care next time. |
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4567/ |
|
@thompsongl anything else i need to do for this PR!? |
Solved issue #4544: Defined getDefaultEuiMarkdownUiPlugins's return type as EuiMarkdownEditorUiPlugin[]
Checklist
[ ] Check against all themes for compatibility in both light and dark modes[ ] Checked in mobile[ ] Checked in Chrome, Safari, Edge, and Firefox[ ] Props have proper autodocs and playground toggles[ ] Added documentation[ ] Checked Code Sandbox works for the any docs examples[ ] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes