-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed htmlIdGenerator import #4682
Conversation
💚 CLA has been signed |
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Jenkins, test this |
👋 Welcome @gebeto ! I got CI (Jenkins) started for you which will run our tests and get a preview built. Quick note, because this is a docs-only change, it actually does not need a changelog. Our Github bot doesn't know this, so sorry for that confusion. I'll add the appropriate labels. |
Oh nevermind, I was mistaken, this IS in the component itself. 👀 |
Fixed htmlIdGenerator import
Preview documentation changes for this PR: https://eui.elastic.co/pr_4682/ |
Thanks @cchaos ! There was one mistake made by me in CHANGELOG.md so I've fixed it and pushed new changes. Can you please run CI again? |
Co-authored-by: Caroline Horn <[email protected]>
Jenkins, test this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for this fix! 🎉 Surprised our CI build didn't catch it in the first place. I'll merge when CI is green.
With one last CL fix 🤦
Preview documentation changes for this PR: https://eui.elastic.co/pr_4682/ |
System error running the accessibility tests, retrying: jenkins test this |
Decided to merge that CL change real quick before Jenkins go too far in. Jenkins, test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4682/ |
Known flaky test that time 🤦: jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4682/ |
Fixed htmlIdGenerator import
Summary
Fixed bad imported htmlIdGenerator that throwing an error on build my(and any other) project