Add onChange callback to search config object. #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #446 |
nreese
reviewed
Mar 7, 2018
| @@ -112,6 +113,10 @@ export class EuiInMemoryTable extends React.Component { | |||
| } | |||
|
|
|||
| onQueryChange(query) { | |||
| if (this.props.search.onChange) { | |||
| return this.props.search.onChange(query); | |||
There was a problem hiding this comment.
I don't think this should return. There are cases where the consumer will want the table to filter the results like normal. This is just a callback that gives the consumer the option to fetch new results if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added an example in this PR in which the input handler is debounced so that the search is executed once you're done typing, instead of executed as you type. I'd like to improve this UX so that we can bypass the debounce and execute the search immediately if the user hits ENTER.
I think I'll implement this in a separate PR, in which we change
EuiFieldSearchto accept anonChangeprop (called as you type) and anonSearchprop (called when you hit enter).