Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiFormRow] Changed the helpText prop to accept an array of messages #4782

Merged
merged 3 commits into from
May 13, 2021
Merged

[EuiFormRow] Changed the helpText prop to accept an array of messages #4782

merged 3 commits into from
May 13, 2021

Conversation

hetanthakkar
Copy link
Contributor

@hetanthakkar hetanthakkar commented May 5, 2021 •
edited by miukimiu
Loading

Summary

Fixes #4775

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs and playground toggles
  • Added documentation
  • Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@hetanthakkar
Copy link
Contributor Author

@cchaos I am a bit skeptical about my approach and the modifications I made in test

@cchaos
Copy link
Contributor

cchaos commented May 5, 2021

Thanks @hetanthakkar1. Can you please add some screenshots of this working?

@hetanthakkar
Copy link
Contributor Author

hetanthakkar commented May 5, 2021 •
edited
Loading

@cchaos This is how it looks
image

@miukimiu miukimiu changed the title Changed the helpText prope in EuiFormRow to accept an array of messages Changed the helpText prop in EuiFormRow to accept an array of messages May 6, 2021
@cchaos
Copy link
Contributor

cchaos commented May 6, 2021

Jenkins, test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4782/

@thompsongl thompsongl self-requested a review May 6, 2021 14:13
@hetanthakkar
Copy link
Contributor Author

@thompsongl anything more that can be done!? or needs to be changed

@miukimiu miukimiu self-requested a review May 12, 2021 12:54
@miukimiu
Copy link
Contributor

jenkins test this

@miukimiu miukimiu changed the title Changed the helpText prop in EuiFormRow to accept an array of messages [EuiFormRow] Changed the helpText prop to accept an array of messages May 13, 2021
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4782/

miukimiu
miukimiu approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@miukimiu miukimiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hetanthakkar1,
Tested locally and on different browsers. LGTM! 🎉

thompsongl
thompsongl approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM!

@miukimiu miukimiu merged commit 0b660a5 into elastic:master May 13, 2021
@hetanthakkar
Copy link
Contributor Author

thank you elastic team @miukimiu @thompsongl and everyone for the review!

@thompsongl thompsongl mentioned this pull request Jun 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miukimiu miukimiu miukimiu approved these changes

@thompsongl thompsongl thompsongl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[EuiFormRow] Allow helpText to take in an array of messages just like error does
5 participants
@hetanthakkar @kibanamachine @cchaos @miukimiu @thompsongl